-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support MODULE.bazel file #647
base: master
Are you sure you want to change the base?
support MODULE.bazel file #647
Conversation
I think this is a great change! Would you be willing to add a new e2e test based on the |
Thanks @achew22! What specific changes to a I ask because I noticed that none of the tests in simple_test.go test modifications to I considered loading a macro via In light of this my opinion is that an e2e test exercising |
I did some experimentation and investigation and found that |
@achew22 Is there a way to get this PR merged? |
71643b4
to
33372b7
Compare
@klandergren any chance you get the builds working so this pr can be merged? |
@achew22 Is there a way to get more detailed logs from the failed Windows build? It looks like it just aborts at some point without a specific error message. Or maybe that test is just flaky and needs to be triggered again? |
The only additional information I have been able to find is on the artifacts tab. Unfortunately, windows remains hostile to people wanting to develop software for it. |
addresses #646
ibazel
with this patch can correctly watch and run the target in the linked issue//internal/ibazel/workspace:workspace_test
passes